Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes when using the "--touch" option. #80

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

patman-cp
Copy link
Contributor

Fix memory to be mapped read/write, so that the "touch" option can write to it.

Signed-off-by: Patrick Mansfield patrick.mansfield@cpacketnetworks.com

Fix memory to be mapped read/write, so that the "touch" option can write to it.

Signed-off-by: Patrick Mansfield <patrick.mansfield@cpacketnetworks.com>
Copy link
Contributor Author

@patman-cp patman-cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shmtest test script didn't work for me, I manually ran some simple tests with "--touch" commands, these:

./numactl --length=20m --shm=A --touch
./numactl --length 10485760 --file B --membind 1 --touch

Without the fix, both the above will seg fault.

@bessonc
Copy link

bessonc commented Oct 16, 2019

This patch also fixes the issue for me (no more segfaults)

@andikleen andikleen merged commit a47463a into numactl:master Oct 16, 2019
@andikleen
Copy link
Contributor

Thanks!

@harish-24
Copy link
Contributor

1 similar comment
@harish-24
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants