numastat.8: clarify that information relates to resident pages #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis clang 5 & 6 apt-get errors are unrelated to this patch. |
|
"Virtual memory mappings are not counted" is not accurate. After all the virtual mapping could have (and likely has) memory backing it, then it would be counted. The first sentence is ok. |
The man page gives no hint about whether memory usage information relates to resident pages or virtual memory. The answer may not be obvious to the user, so explicitly mention that only resident pages are counted. Suggested-by: Daniele Palumbo <daniele@retaggio.net> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
stefanha
force-pushed
the
numastat-man-resident-vs-virtual
branch
from
1afe8a3 to
56806b0
Compare
|
@andikleen Thanks, I have updated the commit. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The man page gives no hint about whether memory usage information
relates to resident pages or virtual memory. The answer may not be
obvious to the user, so explicitly mention that only resident pages are
counted.
Suggested-by: Daniele Palumbo daniele@retaggio.net
Signed-off-by: Stefan Hajnoczi stefanha@redhat.com