Allow linking with lld by deduplicating symbols #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lld appears to be more strict than GNU ld about duplicate exported symbols: it appears that inherited symbols in the export specification from a previous version should not be repeated. This change removes from version 1.2 of the set of exported symbols those symbols which are already included in the set for version 1.1. This allows numactl to be compiled with lld without any errors. Fixes #46
|
Thanks! |
|
Kindly asking for new release with this fix included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lld appears to be more strict than GNU ld about duplicate exported
symbols: it appears that inherited symbols in the export specification
from a previous version should not be repeated.
This change removes from version 1.2 of the set of exported symbols
those symbols which are already included in the set for version 1.1.
This allows numactl to be compiled with lld without any errors.
Fixes #46