Fix: node_list with memory-less nodes #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harish-24
force-pushed
the
fix_memless_node
branch
from
7023279 to
81d115c
Compare
filbranden
reviewed
Jun 21, 2018
numademo.c
Outdated
|
|
||
| numnodes = numa_num_configured_nodes(); | ||
| node_to_use = (int *)malloc(numnodes * sizeof(int)); | ||
| max_node = numa_max_node(); | ||
| for (a = 0; a <= max_node; a++) { | ||
| if(numa_node_size(a, &free_node_sizes) != -1) |
There was a problem hiding this comment.
How about this instead?
if (numa_node_size(a, &free_node_sizes) > 0)(Nitpick: we usually do a space between if (or for, while, etc.) and the initial (, also to differentiate them from function calls.)
test/distance.c
Outdated
| @@ -17,7 +17,7 @@ int main(void) | |||
| node_to_use = (int *)malloc(numnodes * sizeof(int)); | |||
| for (a = 0; a <= maxnode; a++) { | |||
| size = numa_node_size(a, &free_node_sizes); | |||
| if(size != -1) | |||
| if((size != -1) && (size != 0)) | |||
|
Also suggestion to use "memory-less" (or perhaps "memoryless") instead of "memory less" in the commit description. "memory less" looks like the "less" is referring to "nodes" at a glance... |
|
@filbranden Sure, make sense. Thanks for the comments. |
harish-24
force-pushed
the
fix_memless_node
branch
from
81d115c to
9974ec6
Compare
harish-24
changed the title
|
@filbranden There is another issue with |
harish-24
force-pushed
the
fix_memless_node
branch
from
9974ec6 to
036b6d9
Compare
Patch adds check to avoid memory-less nodes while traversing till max node, and this also prevents nodes_to_use sysmalloc failure as nodes_to_use is malloc'ed with numa_num_configured_nodes which returns the number of nodes configured with memory. Signed-off-by: Harish <harish@linux.vnet.ibm.com>
harish-24
force-pushed
the
fix_memless_node
branch
from
036b6d9 to
e033221
Compare
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch adds check to avoid memory-less nodes while traversing till max node, and this also prevents nodes_to_use sysmalloc failure as nodes_to_use is malloc'ed with numa_num_configured_nodes which
returns the number of nodes configured with memory.
Signed-off-by: Harish harish@linux.vnet.ibm.com