build: Refactor autotools setup to store version in separate file #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store the version number in a `VERSION` file at the top of the tree. This makes it easy to parse the current version by reading the contents of the file, and also update it (manually or programatically) when creating a new release. Use m4 macros to read the version into the autotools configuration script. Also update it from 2.0.14 to 2.0.15, since a 2.0.15 version was released but the version inside the configure script was not updated. (We will soon release a 2.0.16, but let's include this configuration change there.) Tested: `make distcheck` passes, confirmed that the `VERSION` file is included inside the generated `numactl-2.0.15.tar.gz` tarball (which should make a further `./autogen.sh` run succeed.) Signed-off-by: Filipe Brandenburger <filbranden@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the version number in a
VERSIONfile at the top of the tree.This makes it easy to parse the current version by reading the contents of the file, and also update it (manually or programatically) when creating a new release.
Use m4 macros to read the version into the
configure.acautotools configuration script. (This recipe came from this StackOverflow answer.)Also update it from 2.0.14 to 2.0.15, since a 2.0.15 version was released but the version inside the configure script was not updated. (We will soon release a 2.0.16, but let's include this configuration change there.)
Tested:
make distcheckpasses, confirmed that theVERSIONfile is included inside the generatednumactl-2.0.15.tar.gztarball (which should make a further./autogen.shrun succeed.)This should also help with #140 to automate creating a new release via GH Actions.