Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the code to make it look cleancode and fix some issues #132

Merged
merged 8 commits into from
Aug 25, 2022
Merged

Modify the code to make it look cleancode and fix some issues #132

merged 8 commits into from
Aug 25, 2022

Conversation

luochenglcs
Copy link
Collaborator

1-4th commit to cleanup code simply.
5th commit fix memory and file handle leak in shm.c
6-8th commit fix memhog issue.

My work focuses on kernel memory management, I was interested in this package.
can I be a maintainer of this repository?

luochunsheng added 8 commits August 24, 2022 16:00
Declares a variable that is used only in a
function as a local variable.
Declares a global variable that is used only
in one file as a static global variable.
The static modifier should be used when
the function is used in only one file.
The execution result of `memhog -r6 1G --membind 0 -fmemhog.mmap`
in manuals isn't as expected, it directly use the last assignment
of p, "default", not "membind". We remove the '-' character and
then match it.
`memhog 1G memb` can work, it will cause misunderstanding.
 When the parameter is incorrect, Now it directly use the
last assignment of p, "default".After the fixed, the usage
will be displayed in this case.
`memhog 1G local` will cause crash, because local policy don't
need nodelist, but we still parse nodestring.
@andikleen andikleen merged commit 6643445 into numactl:master Aug 25, 2022
@andikleen
Copy link
Contributor

Thanks I merged the changes. Currently we're not looking for new maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants