Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bash needs a noop if TLS isn't found. #103

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Bash needs a noop if TLS isn't found. #103

merged 1 commit into from
Feb 24, 2021

Conversation

rblake-llnl
Copy link
Contributor

Fix is from spack/spack#21894

This bug fixes failures to configure on a number of HPC platforms

checking whether we are using the GNU C compiler... (cached) yes
checking whether /usr/WS2/blake14/spack/lib/spack/env/gcc/gcc accepts -g... (cached) yes
checking for /usr/WS2/blake14/spack/lib/spack/env/gcc/gcc option to accept ISO C89... (cached) none needed
checking whether /usr/WS2/blake14/spack/lib/spack/env/gcc/gcc understands -c and -o together... (cached) yes
checking dependency style of /usr/WS2/blake14/spack/lib/spack/env/gcc/gcc... (cached) gcc3
checking for thread local storage (TLS) class... _Thread_local
/g/g19/blake14/sand/numactl_fix/numactl/configure: line 12191: syntax error near unexpected token `fi'
/g/g19/blake14/sand/numactl_fix/numactl/configure: line 12191: `fi'

@rblake-llnl rblake-llnl mentioned this pull request Feb 24, 2021
Merged
@andikleen andikleen merged commit b46666e into numactl:master Feb 24, 2021
@andikleen
Copy link
Contributor

Thanks!

@rblake-llnl rblake-llnl deleted the tls_not_found_error branch February 24, 2021 01:30
rblake-llnl added a commit to rblake-llnl/spack that referenced this pull request Feb 24, 2021
@rblake-llnl
Upstream has fix, will be out in next version.
e6ef3b2 
numactl/numactl#103
becker33 pushed a commit to spack/spack that referenced this pull request Feb 24, 2021
@rblake-llnl
numactl: no-op needed if configure can't find TLS (#21894)
0389f51 
* numactl: Bash needs no-op if configure can't find TLS

* Upstream has fix, will be out in next version.

numactl/numactl#103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rblake-llnl @andikleen