Fix state-flow pretty-printing for :actual in test result #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a custom tag resulted in problems in cider because of this change: clojure-emacs/cider-nrepl@dff71aa
michaelweisser
force-pushed
the
fix-match-for-cider
branch
from
3ddcd0a to
c76e4fc
Compare
ericdallo
approved these changes
Jan 31, 2022
|
Same error ocurring (before the patch) in calva/vsscode
and is fixed on new version
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a change in cider-nrepl ( clojure-emacs/cider-nrepl@dff71aa ), emacs cider wasn't printing the "actual" part of a matcher combinator result correctly. This can be seen on the right side of the screen shot. Cider includes
:summary ...which shouldn't appear. The output as it should be can be seen on the left.With this patch, we are using matcher-combinator's meta tag for mismatches. This way, cider-nrepl will use the dispatching print function and the "actual" section of the test result will be pretty-printed as usual.
Fixes https://nubank.atlassian.net/browse/DEV-471