move match? exception to flow execution time #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchelimsky
force-pushed
the
dc/move-match-warning-to-macro-run-time
branch
from
7b80eb0 to
b9dc683
Compare
dchelimsky
changed the title
dchelimsky
commented
May 18, 2020
| @@ -101,11 +101,12 @@ | |||
| (testing "with times-to-try > 1 and a value instead of a step" | |||
| (testing "throws" | |||
| (is (re-find #"actual must be a step or a flow when :times-to-try > 1" | |||
| (.. (try | |||
| (eval `(mc/match? 3 (+ 30 7) {:times-to-try 2})) | |||
There was a problem hiding this comment.
eval here was a hint that we were doing it wrong.
dchelimsky
commented
May 19, 2020
| @@ -10,7 +10,8 @@ | |||
| (let [params* (merge {:times-to-try probe/default-times-to-try | |||
| :sleep-time probe/default-sleep-time | |||
| :caller-meta (meta &form) | |||
| :description match-desc} | |||
| :description match-desc | |||
| :called-from-deprecated-match? true} | |||
There was a problem hiding this comment.
This is used to tell the non-deprecated version of match? not to throw the times-to-throw exception so that when people upgrade from state-flow < 2.2.4, they don't start seeing exceptions right away.
There was a problem hiding this comment.
The rationale here is that the old default for times-to-try is 5, so the old match? was raising exceptions in a lot of cases by default.
fernando-nubank
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
match?would raise an exception at macroexpansion time if it was called in a syntactically correct by semantically incorrect way. With this PR, the update happens at flow execution time instead.Additionally, in order to reduce upgrade friction, that exception is not thrown at all when calling the deprecated
state-flow.cljtest/match?fn.