Add state-flow.state/runner to access the runner within flows #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelzlisboa
approved these changes
May 14, 2020
|
Which is the use case of this? When I could want to access the runner from a flow? |
It's for helpers that need to run a flow within a flow in order to wrap it in some other function (e.g. |
sovelten
reviewed
May 14, 2020
src/state_flow/state.clj
Outdated
| @@ -113,3 +113,9 @@ | |||
| (if (state? value) | |||
| value | |||
| (return value))) | |||
|
|
|||
| (defn runner | |||
There was a problem hiding this comment.
Now this is part of core, no? runner is defined in core and meta is also something related to core.
sovelten
reviewed
May 14, 2020
test/state_flow/state_test.clj
Outdated
| @@ -2,6 +2,7 @@ | |||
| (:require [cats.core :as m] | |||
| [cats.monad.exception :as e] | |||
| [clojure.test :as t :refer [deftest is testing]] | |||
| [state-flow.core :as state-flow] | |||
There was a problem hiding this comment.
You shouldn't declare core on state_test.clj namespace
sovelten
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.