Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6: fix bad ipv6 format (#1890) #2651

Merged
merged 2 commits into from
Dec 20, 2024
Merged

IPv6: fix bad ipv6 format (#1890) #2651

merged 2 commits into from
Dec 20, 2024

Conversation

paolomonti
Copy link
Contributor

@paolomonti paolomonti commented Dec 19, 2024

Please sign (check) the below before submitting the Pull Request:

Link to the related issue:

Describe changes:
Fixes #1890
IPv6 addresses already containing "::" token shall not be searched for ":0:" nor patched,
therefore ndpi_patchIPv6Address returns immediately in case "::" is found.

ipv6 addresses already containing "::" token shall
not be searched for ":0:" nor patched
@IvanNardi
Copy link
Collaborator

@paolomonti, could you sign the CLA, please?

@IvanNardi
Copy link
Collaborator

@paolomonti, could you update the unit tests results, please?
Something like:

NDPI_FORCE_UPDATING_UTESTS_RESULTS=1 ./tests/do.sh

and commit the modified files

@paolomonti paolomonti closed this Dec 19, 2024
@paolomonti paolomonti reopened this Dec 19, 2024
@paolomonti
Copy link
Contributor Author

tests ok, cla sent

@IvanNardi IvanNardi merged commit 3b602e7 into ntop:dev Dec 20, 2024
34 checks passed
@IvanNardi
Copy link
Collaborator

@paolomonti, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A bug with ipv6 address format
2 participants