Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: add a new fuzzer to test serialization/deserialization code #1876

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

IvanNardi
Copy link
Collaborator

No description provided.

@IvanNardi IvanNardi marked this pull request as draft January 25, 2023 20:28
@IvanNardi IvanNardi force-pushed the fuzz-serialization-like-unit branch from 83fe6bd to d8ee8c9 Compare January 26, 2023 07:59
@IvanNardi IvanNardi marked this pull request as ready for review January 26, 2023 08:01
Autodetecting the needed buffer size is quite complex (especially with
float/double values) so it is mandatory to properly check for
`ndpi_snprintf` truncation.
These issues have been undetected so far probably because the default
buffer is big enough for all common cases.

Add an example of usage of `ndpi_deserialize_clone_all()` (taken from
`ntopng`)
@IvanNardi IvanNardi force-pushed the fuzz-serialization-like-unit branch from d8ee8c9 to f460cce Compare January 26, 2023 08:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@utoni utoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not a fan of checking in all those binary files. But I get the reason behind that.

@IvanNardi IvanNardi merged commit 6d00a9e into ntop:dev Jan 27, 2023
@IvanNardi IvanNardi deleted the fuzz-serialization-like-unit branch January 27, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants