fix: remove polyfills which are out of range of our engines (#35)

The polyfills removed are: - file-url-to-path.js - mkdir.js
npm · Jul 20, 2022 · be1e7b2 · be1e7b2
1 parent 957d1ac
commit be1e7b2
Show file tree

Hide file tree

Showing 13 changed files with 29 additions and 560 deletions.
diff --git a/lib/common/file-url-to-path/index.js b/lib/common/file-url-to-path/index.js
diff --git a/lib/common/file-url-to-path/polyfill.js b/lib/common/file-url-to-path/polyfill.js
diff --git a/lib/common/owner-sync.js b/lib/common/owner-sync.js
@@ -1,6 +1,6 @@
 const { dirname, resolve } = require('path')
+const url = require('url')
 
-const fileURLToPath = require('./file-url-to-path/index.js')
 const fs = require('../fs.js')
 
 // given a path, find the owner of the nearest parent
@@ -13,7 +13,7 @@ const find = (path) => {
   // fs methods accept URL objects with a scheme of file: so we need to unwrap
   // those into an actual path string before we can resolve it
   const resolved = path != null && path.href && path.origin
-    ? resolve(fileURLToPath(path))
+    ? resolve(url.fileURLToPath(path))
     : resolve(path)
 
   let stat

diff --git a/lib/common/owner.js b/lib/common/owner.js
@@ -1,6 +1,6 @@
 const { dirname, resolve } = require('path')
+const url = require('url')
 
-const fileURLToPath = require('./file-url-to-path/index.js')
 const fs = require('../fs.js')
 
 // given a path, find the owner of the nearest parent
@@ -13,7 +13,7 @@ const find = async (path) => {
   // fs methods accept URL objects with a scheme of file: so we need to unwrap
   // those into an actual path string before we can resolve it
   const resolved = path != null && path.href && path.origin
-    ? resolve(fileURLToPath(path))
+    ? resolve(url.fileURLToPath(path))
     : resolve(path)
 
   let stat

diff --git a/lib/index.js b/lib/index.js
@@ -2,7 +2,7 @@ module.exports = {
   ...require('./fs.js'),
   copyFile: require('./copy-file.js'),
   cp: require('./cp/index.js'),
-  mkdir: require('./mkdir/index.js'),
+  mkdir: require('./mkdir.js'),
   mkdtemp: require('./mkdtemp.js'),
   rm: require('./rm/index.js'),
   withTempDir: require('./with-temp-dir.js'),

diff --git a/lib/mkdir.js b/lib/mkdir.js
@@ -0,0 +1,19 @@
+const fs = require('./fs.js')
+const getOptions = require('./common/get-options.js')
+const withOwner = require('./with-owner.js')
+
+// extends mkdir with the ability to specify an owner of the new dir
+const mkdir = async (path, opts) => {
+  const options = getOptions(opts, {
+    copy: ['mode', 'recursive'],
+    wrap: 'mode',
+  })
+
+  return withOwner(
+    path,
+    () => fs.mkdir(path, options),
+    opts
+  )
+}
+
+module.exports = mkdir
diff --git a/lib/mkdir/index.js b/lib/mkdir/index.js
diff --git a/lib/mkdir/polyfill.js b/lib/mkdir/polyfill.js
diff --git a/lib/with-temp-dir.js b/lib/with-temp-dir.js
@@ -1,7 +1,7 @@
 const { join, sep } = require('path')
 
 const getOptions = require('./common/get-options.js')
-const mkdir = require('./mkdir/index.js')
+const mkdir = require('./mkdir.js')
 const mkdtemp = require('./mkdtemp.js')
 const rm = require('./rm/index.js')
 

diff --git a/test/common/file-url-to-path/index.js → test/common/file-url-to-path.js b/test/common/file-url-to-path/index.js → test/common/file-url-to-path.js
@@ -1,11 +1,10 @@
 const t = require('tap')
-
-const fileURLToPath = require('../../../lib/common/file-url-to-path/index.js')
+const url = require('url')
 
 t.test('can convert a file url to a path', async (t) => {
-  const url = process.platform === 'win32'
+  const u = process.platform === 'win32'
     ? 'file://c:/some/path' // windows requires an absolute path, or hostname
     : 'file:///some/path' // posix cannot have a hostname
-  const path = fileURLToPath(url)
+  const path = url.fileURLToPath(u)
   t.type(path, 'string', 'result is a string')
 })