Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do less work looking up commands #6283

Merged
merged 1 commit into from
Mar 29, 2023
Merged

fix: do less work looking up commands #6283

merged 1 commit into from
Mar 29, 2023

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Mar 23, 2023

"plumbing" only existed to keep help-search acting like a command without actually being a command? But it is a command. With a docs page and everything.

@wraithgar wraithgar requested a review from a team as a code owner March 23, 2023 21:44
@wraithgar wraithgar requested review from nlf and removed request for a team March 23, 2023 21:44
lib/npm.js Show resolved Hide resolved
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Mar 23, 2023

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 34.799 ±2.01 15.710 ±0.10 14.593 ±0.28 17.168 ±0.17 3.081 ±0.14 2.825 ±0.01 2.150 ±0.03 10.641 ±0.23 2.207 ±0.02 3.354 ±0.18 0.480 ±0.00 0.497 ±0.01
#6283 37.601 ±0.95 16.874 ±0.04 15.485 ±0.05 18.552 ±1.09 2.904 ±0.04 2.909 ±0.01 2.258 ±0.03 10.809 ±0.13 2.212 ±0.01 3.381 ±0.15 0.503 ±0.01 0.536 ±0.02
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 25.740 ±1.07 12.870 ±0.22 11.625 ±0.15 12.350 ±0.57 2.561 ±0.00 2.605 ±0.01 2.251 ±0.01 7.779 ±0.14 2.068 ±0.01 3.127 ±0.12 0.480 ±0.01 0.498 ±0.01
#6283 26.048 ±0.33 12.914 ±0.14 11.898 ±0.11 12.649 ±0.14 2.659 ±0.07 2.573 ±0.04 2.285 ±0.08 8.068 ±0.02 2.056 ±0.02 3.050 ±0.03 0.498 ±0.00 0.502 ±0.00

@wraithgar wraithgar force-pushed the gar/cmd-sort branch 4 times, most recently from 3d6d9ac to f7a5ed7 Compare March 27, 2023 16:23
@wraithgar
Copy link
Member Author

Once #6286 lands this can be rebased against it and hopefully the flaky tests will pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants