[libs] Peg filetime to 0.2.5 for rust 1.26.1 compat #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filetime started requiring Rust 2018 with version 0.2.6, so version 0.2.5 has to be set explicitly to the build to succeed.
|
Also, these changes to filetime happened 7 days ago, this is why it hasn't popped up before, since the last time the try-v4 branch was built is 14 days ago. |
|
Thanks for that. |
passcod
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some digging I found that the build failure happens, because filetime changed its interface after version 0.2.5 and requires Rust 2018 now. This shouldn't happen in a minor version, but it did.
The last commit that builds with Rust 1.26.1 is this one. After that there are various different build failures.
This means any fresh build of notify is going to fail if it picks up the newest filetime version. I fixed this by hard-coding the lastest working version 0.2.5, which makes the build go through.
Since it's unrelated to the PollWatches Sync thing I made this a separate pull request.