Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish 5.x version to include the license file(s)? #460

Closed
erickt opened this issue Dec 23, 2022 · 7 comments · Fixed by #461
Closed

Publish 5.x version to include the license file(s)? #460

erickt opened this issue Dec 23, 2022 · 7 comments · Fixed by #461

Comments

@erickt
Copy link
Contributor

erickt commented Dec 23, 2022

Hello all,

I noticed that the 5.0.0 notify crate does not include a license file. Would it be possible to release a point release to include the actual license text in the crate?

Thanks, that'll help make it easier to use.

@0xpr03
Copy link
Member

0xpr03 commented Dec 23, 2022

What do I have to do for that ? Because I didn't change anything in the project regarding the license since pre 5.0, so it being missing means cargo didn't include it ?

@erickt
Copy link
Contributor Author

erickt commented Dec 23, 2022

I think this happened when notify shifted over to using workspaces. By default it'll pick up the license files where you ran it, but I don't think this happens by default with workspaces. In my projects, I just symlink to the loplevel license, with something like this:

% cd notify
% ln -s ../LICENSE
% ln -s ../LICENSE.ARTISTIC
% cd ../notify-debouncer-mini
% ln -s ../LICENSE
% ln -s ../LICENSE.ARTISTIC

You can then use cargo package and look in the targets/package to make sure the files are included.

I wasn't sure what's covered by the CC0 or artistic license, so I didn't upload a PR for this.

@JohnTitor
Copy link
Member

Yeah, my some projects, e.g. actix-web also use symbolic links to include license files.

I wasn't sure what's covered by the CC0 or artistic license, so I didn't upload a PR for this.

I'm also not sure, but there's no reason not to do that. I've submitted #461.

@0xpr03
Copy link
Member

0xpr03 commented Dec 23, 2022

Yeah in hindsight it makes total sense that it's not in the actual workspace crate anymore.. Thanks!

@0xpr03 0xpr03 reopened this Dec 23, 2022
@0xpr03
Copy link
Member

0xpr03 commented Dec 23, 2022

Leaving this open until I've done the release

@0xpr03
Copy link
Member

0xpr03 commented Jan 14, 2023

#464

@0xpr03
Copy link
Member

0xpr03 commented Jan 28, 2023

Closed by 85a231f

Edit: debouncer will follow after merging another feature

@0xpr03 0xpr03 closed this as completed Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants