Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push minimum to Rustc 1.32 #201

Closed
passcod opened this issue May 22, 2019 · 2 comments
Closed

Push minimum to Rustc 1.32 #201

passcod opened this issue May 22, 2019 · 2 comments
Labels
Z-needs info Needs more information
Milestone
5.0.0

Comments

@passcod
Copy link
Member

passcod commented May 22, 2019 •
edited
Loading

This is a [major; breaking].

Comment here with things that can be changed/upgraded with this move. 1.32 supports the 2018 Edition.

Looking forward I also want to establish a strategy for pushing the minimum rustc up more regularly: one thought is to support at least N months of rustc, but be free to upgrade from older stuff. However, I intend to maintain the "pushing the minimum rustc is a breaking change" guarantee.

Another way is to allow majors to optionally push the minimum rustc as far as they want (up to the latest stable as of release), but only allow one such push every six months or every year (unless exceptional circumstances), and be conservative about those pushes.
@passcod
Copy link
Member Author

passcod commented May 22, 2019

#199 and #200: filetime crate.

@passcod passcod mentioned this issue May 27, 2019
Closed
@passcod passcod added this to the 5.0.0 milestone May 28, 2019
@0xpr03 0xpr03 added the Z-needs info Needs more information label Mar 6, 2021
@0xpr03
Copy link
Member

0xpr03 commented Mar 22, 2021

I'm closing this as v5 is already on 1.47 as MSRV.

Looking forward I also want to establish a strategy for pushing the minimum rustc up more regularly: one thought is to support at least N months of rustc, but be free to upgrade from older stuff. However, I intend to maintain the "pushing the minimum rustc is a breaking change" guarantee.

I'd only do further MSRV pushes on new major versions (and if only for that matter). cc @JohnTitor in case you disagree with this.

@0xpr03 0xpr03 closed this as completed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Z-needs info Needs more information
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@passcod @0xpr03