Reworking color usage to support a "realistic" render mode, and a "design" render mode #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sign" render mode.
nophead
added a commit
that referenced
this pull request
Mar 16, 2012
Reworking color usage to support a "realistic" render mode, and a "design" render mode
|
It doesn't work. There is a missing ; in colors.scad and it uses variables defined in the machine_configs that are only included later as they need the vitamins that use the colours. |
|
Well that's just weak sauce on my part, and public embarrassment is what I get for trying to do too many things at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach should be more amenable to per-user configuration than my last attempt.