Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix #1040 | Add Namespace Option in Db-Dump (Not Only Default) In PG DB Only #1060

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Bug Fix #1040 | Add Namespace Option in Db-Dump (Not Only Default) In PG DB Only #1060

merged 1 commit into from
Feb 22, 2023

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Feb 22, 2023

Explain the changes

  1. Add namespace option in db-dump (not only default) in PG DB only.

Issues: Fixed #1040 / Gap #1059

  1. Today db-dump works well only with the default namespace.

Testing Instructions:

  1. Based on the instructions here - ‘Build images’.
  2. Deploy Noobaa to a namespace that is different than the default (nb install -n test, for example).
  3. Run: nb diagnose --db-dump --dir=my-db-logs-test -n test.
    Note: nb is an alias that runs the local operator from build/_output/bin (alias created by devenv).

Screenshots:

After running the command (no error):
Screenshot 2023-02-22 at 12 51 32

Viewing the file that was generated (size is above zero bytes):
Screenshot 2023-02-22 at 12 51 50

  • Doc added/updated
  • Tests added

@shirady
add namespace option in db-dump (not only default) in PG DB only
215a256 
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady requested a review from dannyzaken February 22, 2023 10:53
@shirady shirady mentioned this pull request Feb 22, 2023
Closed
2 tasks
@shirady shirady self-assigned this Feb 22, 2023
@shirady shirady requested a review from liranmauda February 22, 2023 13:20
@shirady shirady changed the title Add Namespace Option in Db-Dump (Not Only Default) In PG DB Only Bug Fix #1040 | Add Namespace Option in Db-Dump (Not Only Default) In PG DB Only Feb 22, 2023
liranmauda
liranmauda approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirady shirady merged commit d6a77d2 into noobaa:master Feb 22, 2023
@shirady shirady deleted the fix-db-dump-test-namespace-pg branch February 22, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranmauda liranmauda liranmauda approved these changes

@dannyzaken dannyzaken dannyzaken approved these changes

Assignees

@shirady shirady

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DB-Dump Not Generated In Test Namespace Using PG DB
3 participants
@shirady @dannyzaken @liranmauda