Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loop behavior (Issue #2647) #2651

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Fix loop behavior (Issue #2647) #2651

merged 1 commit into from
Jun 1, 2018

Conversation

kochizufan
Copy link
Contributor

Fixed loop behavior, which reported in issue #2647.

In 10 slides and 2.5 slidesPerView case,

  • Left arrow button stops between Slide 9 and Slide 8 => Fixed
  • 2 swipes are need to move from Slide 9 to Slide 8 => Fixed
  • Slide 8 is often not shown in left of Slide 9 => Fixed

Test is at https://jsfiddle.net/kochizufan/su1ka5ov/

@nolimits4web nolimits4web merged commit 8023852 into nolimits4web:master Jun 1, 2018
@nolimits4web
Copy link
Owner

Awesome, thanks 👍

@nolimits4web nolimits4web mentioned this pull request Jun 1, 2018
Closed
3 tasks
@kochizufan kochizufan mentioned this pull request Jul 7, 2018
Closed
3 tasks
moyus pushed a commit to moyus/swiper-lite that referenced this pull request Sep 5, 2018
@nolimits4web
Merge pull request nolimits4web#2651 from kochizufan/loopFix
db96e63 
Fix loop behavior (Issue nolimits4web#2647)
@lock lock bot added the outdated label Jan 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kochizufan @nolimits4web