enable a11y by default #2490
Merged
enable a11y by default #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, maybe this is a good to enable by default, but it will be a breaking change, as i already see how many issues it will raise with update with a11y enabled because:
|
|
It's better to have some users with screen readers have localisation issues than to have all users with screen readers hear nothing at all, in my opinion. There are some things that could be improved without adding any text though, such as turning the navigation circles into links or buttons. |
Definitely. |
moyus
pushed a commit
to moyus/swiper-lite
that referenced
this pull request
Sep 5, 2018
…able-a11y enable a11y by default
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a11y should be enabled by default like in most frameworks, it should be optout.