fix #6863, update scripts/utils/minify.js to fix source maps for ES modules. #6866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue with the missing ".min" part in the source map URLs, which leads to broken links for .jsm files. The problem is that the URLs are not correctly formed, causing the files to point to non-existing locations. In this code change, we have rectified this problem by ensuring that the source map URLs now include the ".min" part. This adjustment ensures that the links to .jsm files are correctly directed to the appropriate URLs, resolving the problem of broken links. With this fix, the source map URLs will now be accurately generated, and the .jsm files will successfully link to their corresponding source maps, resolving the previously broken links. Fixes nolimits4web#6863
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #6863
This commit addresses an issue with the missing ".min" part in the source map URLs, which leads to broken links for .jsm files. The problem is that the URLs are not correctly formed, causing the files to point to non-existing locations.
In this code change, we have rectified this problem by ensuring that the source map URLs now include the ".min" part. This adjustment ensures that the links to .jsm files are correctly directed to the appropriate URLs, resolving the problem of broken links.
With this fix, the source map URLs will now be accurately generated, and the .jsm files will successfully link to their corresponding source maps, resolving the previously broken links.