Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History plugin fixes and new option adding #5665

Merged
merged 4 commits into from
Apr 26, 2022
Merged

History plugin fixes and new option adding #5665

merged 4 commits into from
Apr 26, 2022

Conversation

VahanMargaryan
Copy link
Contributor

  • [ADDED] (keepQuery) New option to keep the query string parameters when changing user when navigating
  • [FIXED] History back via browser button not working
  • [ADDED] typing for History plugin options
  • enabled?: boolean
  • keepQuery?: boolean

@VahanMargaryan
fixed issue with the history back navigation
5a9f3ca 
[ADD] Added option to keep the query string parameters when changing user when navigating
[FIXED] History back via browser button not working
@VahanMargaryan
Added typing for History plugin options
df01b77 
Added typing for History plugin options
- enabled
- keepQuery
@VahanMargaryan
keepQuery default value: false
0d883af 
Changed the default value of the option keepQuery to false
nolimits4web
nolimits4web requested changes Apr 25, 2022
View reviewed changes
src/modules/history/history.js Outdated Show resolved Hide resolved
@VahanMargaryan
Update history.js
b7fa8bd 
fixed param getting object name
@nolimits4web nolimits4web merged commit 798c7c0 into nolimits4web:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolimits4web nolimits4web nolimits4web requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VahanMargaryan @nolimits4web