Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of life enhancements for CNI delegation code #63

Merged
merged 2 commits into from
Apr 1, 2019

Conversation

Levovar
Copy link
Collaborator

@Levovar Levovar commented Mar 19, 2019

Next up on the what we could do better in DANM is the cnidel package!
The following operability enhancements are also introduced as part of this PR:

  • the CNI config file to be used when delegating to static integration level backends is now configurable via the NetworkID DanmNet API parameter
  • the directory where the static CNI configuration files are searched for is now also configurable, via the CNI_CONF_DIR environment variable (default value is the current hard coding for the sake of backward compatibility)

README and DanmNet schema files were also deserving of some major face lifting.

…important disclaimer about DanmNet deletion to README, updating Glide lock file
@Levovar Levovar force-pushed the cnidel_steroid branch 2 times, most recently from e1c4f60 to cbb40c0 Compare March 19, 2019 03:06
- CNI config directory can be now configured
- it is possible now to define which CNI config is to be used when delegating to static backends. NetworkType: name of the invoked binary, NetworkID: name of the CNI config file

README and DanmNet schema files both got a much deserved facelift
@Levovar Levovar changed the title Quality of life enhancements, unit tests, and bugfixes for cnidel package Quality of life enhancements for CNI delegation code Apr 1, 2019
@Levovar Levovar merged commit 906efc3 into master Apr 1, 2019
@Levovar Levovar deleted the cnidel_steroid branch April 1, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant