-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate MACVLAN CNI to DANM with dynamic integration level + Extend IP route provisioning support to ALL backends #13
Conversation
setupHost in net.go should be adjusted to also handle host interface provisioning for macvlan backend |
Reminder2: vlan/vxlan support for delegated backends should be refactored to be generic, rather than requiring code per-backend |
0d2da1d
to
92a3f20
Compare
The review contains the generalization of how IP route provisioning is handled within DANM. Previously IP routes were only provisioned into a container's netNS if the NEtworkType of the related DanmNet was "ipvlan". The related code was refactored to be generic, and is now invoked from cnidel after a delegated CNI created an interface. Actually there is not much separating the two after this change :) |
The recent refactoring includes:
|
…r ALL backends! IP route provisioning code was streamlined as a result, code duplication was deleted.
DanmEp is now used during the whole delegation process to convey information about creating interfaces. This is now unifies the interfaces between delegated, and non-delegated options, opening up for future, uniform enhancements!
Cleaned-up dual-stack IP hadling too.
…t IP route, and policy-based IP route provsioning.
058abc7
to
8572e9c
Compare
Change is now functional tested, all newly added functionalities work.
Only documentation remains, and we are good to go! |
…red to describe the new generic features.
…"interfaces in the name of PC :)
This will enable the creation of MACVLAN interfaces based on the dynamic DanmNet API.
The CNI used to create the interfaces is the basic CNI coming from:
https://github.com/containernetworking/plugins/blob/master/plugins/main/macvlan/macvlan.go
Interfaces are created in bridge mode, with 1500 MTU.
Change is not yet tested.