Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only throw error responses #1076

Merged
merged 1 commit into from
Oct 27, 2021
Merged

fix: only throw error responses #1076

merged 1 commit into from
Oct 27, 2021

Conversation

ronag
Copy link
Member

@ronag ronag commented Oct 27, 2021

Fixes: #1072

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021 •
edited
Loading

Codecov Report

Merging #1076 (31a89e1) into main (7b03c91) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
+ Coverage   94.97%   95.08%   +0.10%     
==========================================
  Files          39       39              
  Lines        3744     3744              
==========================================
+ Hits         3556     3560       +4     
+ Misses        188      184       -4
Impacted Files Coverage Δ
lib/fetch/index.js 82.16% <100.00%> (+0.21%) ⬆️
lib/fetch/response.js 92.42% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b03c91...31a89e1. Read the comment docs.

mcollina
mcollina approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 48d9578 into main Oct 27, 2021
@mcollina mcollina deleted the manual-redirect branch October 27, 2021 14:18
ronag added a commit that referenced this pull request Oct 28, 2021
@ronag
fix: only throw error responses (#1076)
fd35540 
Fixes: #1072
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
@ronag @KhafraDev
fix: only throw error responses (nodejs#1076)
505d95b 
Fixes: nodejs#1072
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
@ronag @crysmags
fix: only throw error responses (nodejs#1076)
166e9b5 
Fixes: nodejs#1072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError when redirect is set to 'manual'
3 participants
@ronag @codecov-commenter @mcollina