Skip to content

Dispatcher.connect doesn't include origin field #2531

Closed
@dvoytenko

Description

Bug Description

ConnectOptions interface doesn't include an origin field that's required for the HTTP CONNECT.

Furthermore, it appears that the agent.connect({}) currently fails to execute without the origin field.

Reproducible By

const agent = new Agent();
agent.connect({
  origin: "https://example.com",
  path: "/robots.txt"
 });

This gives a TypeScript error for unknown "origin" field.

Expected Behavior

Origin is accepted.

Environment

Any

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    TypesChanges related to the TypeScript definitionsbugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions