-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "tools: open issue when update workflow fails" #48312
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
marco-ippolito:revert/open-issue-dep-update-fail
Jun 3, 2023
Merged
Revert "tools: open issue when update workflow fails" #48312
nodejs-github-bot
merged 1 commit into
nodejs:main
from
marco-ippolito:revert/open-issue-dep-update-fail
Jun 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c488558.
Review requested:
|
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Jun 3, 2023
richardlau
approved these changes
Jun 3, 2023
Mesteery
approved these changes
Jun 3, 2023
marco-ippolito
added
fast-track
PRs that do not need to wait for 48 hours to land.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Jun 3, 2023
Fast-track has been requested by @marco-ippolito. Please 👍 to approve. |
Why did the step run at all? #48308 was opened by a manual run, wasn't it? |
aduh95
approved these changes
Jun 3, 2023
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 3, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 3, 2023
Landed in fdf8ecd |
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
This reverts commit c488558. PR-URL: nodejs#48312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
This reverts commit c488558. PR-URL: nodejs#48312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
This reverts commit c488558. PR-URL: nodejs#48312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fast-track
PRs that do not need to wait for 48 hours to land.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c488558.
the action creates an issue that dep update failed: #48309 but actually worked #48308, while other jobs failed