doc: first pass at minimal-kernel #180

MylesBorins · 2018-09-12T20:22:03Z

Decided to submit this as a PR to comment and land as documentation.

Thoughts?

MylesBorins · 2018-09-12T21:56:37Z

updated based on feedback.

Biggest changes

expand minimal kernel
- added dynamic import
- added import.meta.url
documented PRs that implement the kernel

* Rewrite: emphasize that minimal kernel is just the first phase of a multistage process, add more features and more links to features, use complete sentences.

MylesBorins · 2018-09-20T19:47:03Z

Updated significantly based on feedback I received from @GeoffreyBooth

As such I'm dismissing all current reviews. PTAL

Significant changes since review

GeoffreyBooth · 2018-09-20T21:22:04Z

Rich-formatted version: https://github.com/nodejs/modules/blob/aa9a20b1812901d4d858dd7bb556a736ed95b2a6/doc/plan-for-new-modules-implementation.md

Thanks @MylesBorins

SMotaal · 2018-09-21T22:53:10Z

Amazing!

Refs: nodejs/modules#180

Refs: nodejs/modules#180 PR-URL: #6 PR-URL: #12 Co-authored-by: Myles Borins <MylesBorins@google.com> Co-authored-by: John-David Dalton <john.david.dalton@gmail.com>

Refs: https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal Refs: nodejs/modules#180 Refs: #6 Refs: #12 Refs: #28 Co-authored-by: Myles Borins <MylesBorins@google.com> Co-authored-by: John-David Dalton <john.david.dalton@gmail.com>

This PR updates the current `--experimental-modules` implementation based on the work of the modules team and reflects Phase 2 of our new modules plan. The largest differences from the current implementation include * `packge.type` which can be either `module` or `commonjs` - `type: "commonjs"`: - `.js` is parsed as commonjs - default for entry point without an extension is commonjs - `type: "module"`: - `.js` is parsed as esm - does not support loading JSON or Native Module by default - default for entry point without an extension is esm * `--entry-type=[mode]` - allows you set the type on entry point. * A new file extension `.cjs`. - this is specifically to support importing commonjs in the `module` mode. - this is only in the esm loader, the commonjs loader remains untouched, but the extension will work in the old loader if you use the full file path. * `--es-module-specifier-resolution=[type]` - options are `explicit` (default) and `node` - by default our loader will not allow for optional extensions in the import, the path for a module must include the extension if there is one - by default our loader will not allow for importing directories that have an index file - developers can use `--es-module-specifier-resolution=node` to enable the commonjs specifier resolution algorithm - This is not a “feature” but rather an implementation for experimentation. It is expected to change before the flag is removed * `--experimental-json-loader` - the only way to import json when `"type": "module"` - when enable all `import 'thing.json'` will go through the experimental loader independent of mode - based on whatwg/html#4315 * You can use `package.main` to set an entry point for a module - the file extensions used in main will be resolved based on the `type` of the module Refs: https://github.com/nodejs/modules/blob/master/doc/plan-for-new-modules-implementation.md Refs: https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal Refs: nodejs/modules#180 Refs: nodejs/ecmascript-modules#6 Refs: nodejs/ecmascript-modules#12 Refs: nodejs/ecmascript-modules#28 Refs: nodejs/modules#255 Refs: whatwg/html#4315 Refs: WICG/webcomponents#770 Co-authored-by: Myles Borins <MylesBorins@google.com> Co-authored-by: John-David Dalton <john.david.dalton@gmail.com> Co-authored-by: Evan Plaice <evanplaice@gmail.com> Co-authored-by: Geoffrey Booth <webmaster@geoffreybooth.com> Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: nodejs#26745 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

This PR updates the current `--experimental-modules` implementation based on the work of the modules team and reflects Phase 2 of our new modules plan. The largest differences from the current implementation include * `packge.type` which can be either `module` or `commonjs` - `type: "commonjs"`: - `.js` is parsed as commonjs - default for entry point without an extension is commonjs - `type: "module"`: - `.js` is parsed as esm - does not support loading JSON or Native Module by default - default for entry point without an extension is esm * `--entry-type=[mode]` - allows you set the type on entry point. * A new file extension `.cjs`. - this is specifically to support importing commonjs in the `module` mode. - this is only in the esm loader, the commonjs loader remains untouched, but the extension will work in the old loader if you use the full file path. * `--es-module-specifier-resolution=[type]` - options are `explicit` (default) and `node` - by default our loader will not allow for optional extensions in the import, the path for a module must include the extension if there is one - by default our loader will not allow for importing directories that have an index file - developers can use `--es-module-specifier-resolution=node` to enable the commonjs specifier resolution algorithm - This is not a “feature” but rather an implementation for experimentation. It is expected to change before the flag is removed * `--experimental-json-loader` - the only way to import json when `"type": "module"` - when enable all `import 'thing.json'` will go through the experimental loader independent of mode - based on whatwg/html#4315 * You can use `package.main` to set an entry point for a module - the file extensions used in main will be resolved based on the `type` of the module Refs: https://github.com/nodejs/modules/blob/master/doc/plan-for-new-modules-implementation.md Refs: https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal Refs: nodejs/modules#180 Refs: nodejs/ecmascript-modules#6 Refs: nodejs/ecmascript-modules#12 Refs: nodejs/ecmascript-modules#28 Refs: nodejs/modules#255 Refs: whatwg/html#4315 Refs: WICG/webcomponents#770 Co-authored-by: Myles Borins <MylesBorins@google.com> Co-authored-by: John-David Dalton <john.david.dalton@gmail.com> Co-authored-by: Evan Plaice <evanplaice@gmail.com> Co-authored-by: Geoffrey Booth <webmaster@geoffreybooth.com> Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: #26745 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

MylesBorins force-pushed the minimal-kernel branch from 6569081 to 2cb7451 Compare September 12, 2018 20:22

MylesBorins mentioned this pull request Sep 12, 2018

Managing fork and agreed upon minimal kernel #166

Closed

This comment was marked as off-topic.

Sign in to view

MylesBorins force-pushed the minimal-kernel branch from 2cb7451 to 6f3f5c9 Compare September 12, 2018 20:44

doc: first pass at minimal-kernel

a40b8a9

Refs: nodejs#166

MylesBorins force-pushed the minimal-kernel branch from 6f3f5c9 to a40b8a9 Compare September 12, 2018 21:54

This comment was marked as off-topic.

Sign in to view

Edit of minimal kernel doc (#2)

aa9a20b

* Rewrite: emphasize that minimal kernel is just the first phase of a multistage process, add more features and more links to features, use complete sentences.

This comment was marked as off-topic.

Sign in to view

MylesBorins added the modules-agenda To be discussed in a meeting label Sep 25, 2018

MylesBorins mentioned this pull request Sep 25, 2018

Node.js Foundation Modules Team Meeting 2018-09-26 #187

Closed

SimenB mentioned this pull request Sep 28, 2018

[babel-jest] mjs files jestjs/jest#4637

Closed

MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request Oct 2, 2018

esm: remove .js support

7e5aba7

Refs: nodejs/modules#180

GeoffreyBooth removed modules-agenda To be discussed in a meeting labels May 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: first pass at minimal-kernel #180

doc: first pass at minimal-kernel #180

MylesBorins commented Sep 12, 2018

This comment was marked as off-topic.

MylesBorins commented Sep 12, 2018

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

MylesBorins commented Sep 20, 2018

This comment was marked as off-topic.

GeoffreyBooth commented Sep 20, 2018

SMotaal commented Sep 21, 2018

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

doc: first pass at minimal-kernel #180

doc: first pass at minimal-kernel #180

Conversation

MylesBorins commented Sep 12, 2018

This comment was marked as off-topic.

MylesBorins commented Sep 12, 2018

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

MylesBorins commented Sep 20, 2018

This comment was marked as off-topic.

GeoffreyBooth commented Sep 20, 2018

SMotaal commented Sep 21, 2018

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.