-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non-printable characters inside quoted string literals. #219
Conversation
NB. Speed decrease is ~10% (25% on edge cases). Looks acceptable. |
Looks good, but
|
Disabling of the JSON-style checking for single quoted scalars is a consequence of the following two statements from YAML 1.2 specification: |
You're mixing two independent areas. 5.1 is dumper's concern. Dumper takes JS object and then decides by itself which scalar style to use. 5.7 is out of place at all. It's about I'm just looking for usage of |
OK, I've missed the section 7.3.2, so I'll revert the check for single-quoted scalars back. |
@puzrin, if you think we don't need to try improve the performance, then It's good for merge now. |
Allow non-printable characters inside quoted string literals.
I doubt that regexp unroll for this case will be faster - too many conditions. Let's leave it for someone else, who has time for experiments. |
Fixed issue #192