-
-
Notifications
You must be signed in to change notification settings - Fork 776
Comparing changes
Open a pull request
base repository: nodeca/js-yaml
base: 3.5.5
head repository: nodeca/js-yaml
compare: 3.6.0
- 12 commits
- 24 files changed
- 2 contributors
Commits on Mar 31, 2016
-
Rewrite scalar dumper for correctness
Rewrote the scalar dumper with an emphasis on rigor, based on a careful reading of the YAML 1.2 spec and testing against LibYAML. Corrections: Block style chomping accounts for added the extra newline added by subsequent elements or at the end. Fixes #238. Top-level block scalars are indented. Fixes dumper side of #221. Folded style should be reliable now. The old dumper was not aware of the subtle rules for more-indented lines. More-indented lines no longer cause extra newlines to be added. (The old dumper also had an off-by-one error that dropped the last character from a long first word on a line.) Fixes #215, #222. Removes #217 workaround. Literal and folded styles can represent arbitrary "printable" strings, including leading/trailing whitespace. NB. For the 'construct-string-types' dumper test, the strings are dumped correctly. The test fails because a loader bug loses a newline when using the keep "+" chomping indicator. Additional: Added test suite covering several former bugs, new edge cases, and new expected behaviors. All previous applicable tests are included. Styles are chosen in a well-defined order. Plain and single are preferred for single lines under the width limit. Folded is preferred when a line is longer than the width limit (if enabled) and does not begin with a space. Literal is used for all other multi-line "printable" strings. Double-quoted is only used when a string is unrepresentable otherwise. Plain style is relaxed to include more characters and strings. Progress on #183. As indent increases, line width decreases down to min(lineWidth, 40). Setting lineWidth to -1 disables wrapping. Previously there was unexpected behavior past 40 indent: narrow lineWidth suddenly jumped to 40, and -1 (no limit) suddenly enforced a limit of 40.
Configuration menu - View commit details
-
Copy full SHA for dee2c3b - Browse repository at this point
Copy the full SHA dee2c3bView commit details
Commits on Apr 1, 2016
-
Updated test for #217. It now checks that folded style preserves JS functions and regexps. Replaced String.prototype.repeat with a helper function, for compatibility with node 0.10.
Configuration menu - View commit details
-
Copy full SHA for 927caee - Browse repository at this point
Copy the full SHA 927caeeView commit details
Commits on Apr 4, 2016
-
Merge pull request #274 from aepsilon/rewrite-scalar-dump
Rewrite scalar dumper for correctness
Vitaly Puzrin committedApr 4, 2016 Configuration menu - View commit details
-
Copy full SHA for 4644c6f - Browse repository at this point
Copy the full SHA 4644c6fView commit details -
Changed Buffer use workaround for browser. Fix #275
Vitaly Puzrin committedApr 4, 2016 Configuration menu - View commit details
-
Copy full SHA for 0375c5e - Browse repository at this point
Copy the full SHA 0375c5eView commit details -
assert.equal() -> assert.strictEqual()
Vitaly Puzrin committedApr 4, 2016 Configuration menu - View commit details
-
Copy full SHA for e0c4e4e - Browse repository at this point
Copy the full SHA e0c4e4eView commit details
Commits on Apr 15, 2016
-
Fix block scalar leading/trailing newlines
Fixes #253: loader should not add an extra newline at the beginning of block scalars that have an explicit indentation indicator. Cause: "Detected indent" was assumed logically equivalent to "did read non-empty line". This no longer holds with an indentation indicator: indent is detected before any content is read. Fixes #276: loader should not remove a trailing newline for block scalars with "+" chomping. Cause: "+" chomping didn't account for the last content newline before the trailing empty lines.
Configuration menu - View commit details
-
Copy full SHA for 085bf1d - Browse repository at this point
Copy the full SHA 085bf1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57c398d - Browse repository at this point
Copy the full SHA 57c398dView commit details -
Add benchmark samples for block scalars
Taken from scalar_double_quoted_simple_multiline.yaml
Configuration menu - View commit details
-
Copy full SHA for 10d82a2 - Browse repository at this point
Copy the full SHA 10d82a2View commit details -
Merge pull request #278 from aepsilon/fix-block-newlines
Fix block scalar leading/trailing newlines
Vitaly Puzrin committedApr 15, 2016 Configuration menu - View commit details
-
Copy full SHA for fa11316 - Browse repository at this point
Copy the full SHA fa11316View commit details -
Vitaly Puzrin committed
Apr 15, 2016 Configuration menu - View commit details
-
Copy full SHA for f3f55e8 - Browse repository at this point
Copy the full SHA f3f55e8View commit details -
Vitaly Puzrin committed
Apr 15, 2016 Configuration menu - View commit details
-
Copy full SHA for 3a26b76 - Browse repository at this point
Copy the full SHA 3a26b76View commit details -
Vitaly Puzrin committed
Apr 15, 2016 Configuration menu - View commit details
-
Copy full SHA for 87e4cdc - Browse repository at this point
Copy the full SHA 87e4cdcView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 3.5.5...3.6.0