Updates for the workshop tutorial README #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reconbot
reviewed
Aug 19, 2018
|
|
||
| #### Step 1: Connect the HC-05 module to the Arduino for configuration | ||
|
|
||
| We will program the Arduino to send AT commands to the module to configure it via a SoftwareSerial connection. Wire the TX and RX pins of your module to your Arduino. They need wired in a crossover configuration, so from the module to the Arduino wire TX to pin 10 and RX to pin 11. | ||
| We will program the Arduino to send AT commands to the module to configure it via a SoftwareSerial connection. Wire the TX (transmit) and RX (receive) pins of your module to your Arduino. They need to be wired in a crossover configuration, so from the module to the Arduino wire TX to pin 10 and RX to pin 11. (For the purpose of configuring the Bluetooth module, pin 10 is used as RX on the Arduino, and pin 11 is used as TX. Later, when running Johnny-Five code, we'll use the pins labeled TX and RX on the arduino.) |
There was a problem hiding this comment.
I like the addition but it's still confusing. Might be clearer if it was more sentences?
There was a problem hiding this comment.
👍 I'll merge this for now, so we get the updates, and will take another stab at this section for improving clarity.
|
If we're struggling for clarity & brevity here. Might be worth linking to
the J5 wiki where there is some more detail?
…On Sat, Aug 18, 2018, 21:20 Francis Gulotta ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#7 (comment)>
:
>
#### Step 1: Connect the HC-05 module to the Arduino for configuration
-We will program the Arduino to send AT commands to the module to configure it via a SoftwareSerial connection. Wire the TX and RX pins of your module to your Arduino. They need wired in a crossover configuration, so from the module to the Arduino wire TX to pin 10 and RX to pin 11.
+We will program the Arduino to send AT commands to the module to configure it via a SoftwareSerial connection. Wire the TX (transmit) and RX (receive) pins of your module to your Arduino. They need to be wired in a crossover configuration, so from the module to the Arduino wire TX to pin 10 and RX to pin 11. (For the purpose of configuring the Bluetooth module, pin 10 is used as RX on the Arduino, and pin 11 is used as TX. Later, when running Johnny-Five code, we'll use the pins labeled TX and RX on the arduino.)
I like the addition but it's still confusing. Might be clearer if it was
more sentences?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHRowR2j7uHwnEnro36FWGaeKzcGxisks5uSOedgaJpZM4WCwY1>
.
|
HipsterBrown
approved these changes
Aug 19, 2018
|
@ajfisher I'd be for that. Do you know where in the docs the pertinent info is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly grammatical fixes and workshop-specific clarifications. Also expanded on General Tips in build.md.