Remove examples folder. #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some good examples can be found at - https://github.com/mranney/redis_trace - https://github.com/mranney/http_trace
Closed
|
I'm actually fine with this too, as long as there are enough representative examples linked to explain to people how to use it. |
|
Fixed the examples and removed http trace #146 PS: If you need examples |
|
@mranney I took @vigneshshanmugam's changes for now so that we have them is their any more examples you would like to extract to their own project's prior to their removal? I have opened issue #150 to solicit the community for examples of this library being used. |
jmaxxz
added a commit
that referenced
this pull request
Mar 22, 2015
Conflicts: README.md examples/multiple_interfaces examples/network_grep.js examples/speed_server examples/tcp_metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some good examples can be found at
IMO external repositories are the best places for example applications as it better represents how developers should use this library. Further more it lets the readme and other documentation in this library focus on usage of the library rather than usage of the example scripts.