-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for uploading files to buffer instead of filesystem #267
Conversation
…EST_TMP and TEST_PORT
…EST_TMP and TEST_PORT
Hi @Elzair - thanks for this contribution. I have to admit that I'm a little hesitant when it comes to merging this, as the desired functionality can be provided in userland as well (by defining your own Do you see any compelling reasons why this should be part of formidable itself? |
@Elzair thanks! A bit late here, but if you still using Also, there are issues that want this feature, and if couldn't land at v2, it will be possible to the user to do whatever he want because the #545 Plugin API. Also, because the reason that v2 exports everything - all the parser classes, all the plugins, all the utils, aliases and etc. I'm going to close this, because it's based on pretty old code base. |
@all-contributors please add @Elzair for code and idea |
I've put up a pull request to add @Elzair! 🎉 |
Thanks everyone! |
A while ago, I encountered a problem uploading images >1MB to a Nodejitsu instance. I assume that cloud hosting providers like Nodejitsu do not always support a large filesystem for node.js instances. Since I needed to upload the file to the server before pushing it to an image hosting service, I modified node-formidable to support uploading files to Buffers instead of to the filesystem.