Handle zero-length OK deflate responses #903
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #903 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 579 583 +4
Branches 185 186 +1
=========================================
+ Hits 579 583 +4
Continue to review full report at Codecov.
|
|
@bitinn should we merge this into node-fetch:2.x, master or both? |
|
I think merging into 3.x/master would require tweaking the testing parts a bit. I can open another PR if necessary. |
|
Ping @bitinn and @jimmywarting, any progress on merging this? I can create another PR for master if necessary |
Yes please |
|
@jimmywarting Ok thanks, will do that soon. This will be merged though, right? |
|
yes |
|
Hi @jimmywarting any chance this can be merged now? It's been nearly two years and I was expecting that this would be merged as soon as I ported my changes to the main branch (which I did in #965), but for whatever reason this didn't happened. |
|
ty for the fix, sry it took so long. i guess it was never meant for the v2 branch. |
|
🎉 This issue has been resolved in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.6.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What is the purpose of this pull request?
What changes did you make?
This fixes an issue where older ISS servers (Definitely 7.5, but I can’t rule out other versions), could respond with a zero-length OK deflate response, hanging node-fetch. This was caused by the body stream never emitting a
dataevent. A typical problematic response looks something like this:Is there anything you'd like reviewers to know?
Our codebase uses node-fetch 2.6.0, but this is still an issue in v3. I’m not sure how to go about patching both branches.