Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull request template #825

Merged
merged 3 commits into from
May 23, 2020
Merged

Update pull request template #825

merged 3 commits into from
May 23, 2020

Conversation

NotMoni
Copy link
Member

@NotMoni NotMoni commented May 23, 2020

No description provided.

@Richienb Richienb changed the title update pr template Update pull request template May 23, 2020
@NotMoni NotMoni merged commit 1bd848b into node-fetch:master May 23, 2020
@NotMoni NotMoni deleted the NotMoni-pr-template branch May 23, 2020 12:26
@NotMoni NotMoni restored the NotMoni-pr-template branch May 23, 2020 12:26
@NotMoni NotMoni deleted the NotMoni-pr-template branch May 23, 2020 12:26
@jimmywarting
Copy link
Collaborator

After seeing this in use i feel like the checkboxes are abused a bit

first of all, they should really be radio buttons instead. but github don't support it...

checkboxes are more like task that needs to be completed.

Skärmavbild 2020-06-12 kl  21 51 03

And i don't feel like this is the right way to use them... would it be possible to create multiple PR templates instead with more narrow focus on what kind of PR it is?

@jimmywarting
Copy link
Collaborator

feel like we should remove them, think we can do better

@jimmywarting
Copy link
Collaborator

jimmywarting commented Jun 12, 2020

if it's a bug fix PR then it would be useful with a template that have something like

# Description

<-- Replace this comment with a description! -->

- [ ] created a test case (not suited for docs)
- [ ] Used a meaningful title
- [ ] written a description
- [ ] done code coverage (not suited for docs)
- [ ] Ready to be reviewed (maybe unnecessary - can as well do draft PR)

fixes #000

and maybe some html comments or something

@NotMoni
Copy link
Member Author

NotMoni commented Jun 13, 2020

Will do @jimmywarting

@NotMoni
Copy link
Member Author

NotMoni commented Jun 13, 2020

@jimmywarting @tinovyatkin Should we make multiple TEMPLATE or fit them all in one ?

@NotMoni
Copy link
Member Author

NotMoni commented Jun 13, 2020

I would like to do all in one.

@jimmywarting
Copy link
Collaborator

I would like to do all in one.

ok

@jimmywarting
Copy link
Collaborator

??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants