Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Data URI support #659

Merged
merged 2 commits into from
Sep 7, 2019
Merged

feat: Data URI support #659

merged 2 commits into from
Sep 7, 2019

Conversation

Richienb
Copy link
Member

@Richienb Richienb commented Aug 3, 2019

This PR adds support for Data URIs using native methods in Node 5.10.0+ (closes #311).

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb Richienb mentioned this pull request Aug 3, 2019
@codecov-io
Copy link

codecov-io commented Sep 7, 2019

Codecov Report

Merging #659 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #659   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         587    575   -12     
  Branches      183    183           
=====================================
- Hits          587    575   -12
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️
src/headers.js 100% <0%> (ø) ⬆️
src/body.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95286f5...6235cd9. Read the comment docs.

@Richienb Richienb mentioned this pull request Sep 7, 2019
35 tasks
Copy link
Member

@xxczaki xxczaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants