Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds mset feature #142

Merged
merged 3 commits into from
Sep 5, 2019
Merged

adds mset feature #142

merged 3 commits into from
Sep 5, 2019

Conversation

sujeshthekkepatt
Copy link
Contributor

Adds mset feature. Please take look @erdii . Still needs to add the tests. Once the code seems okay I will add the tests.

erdii
erdii requested changes Sep 2, 2019
View reviewed changes
Copy link
Member

@erdii erdii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good :)

_src/lib/node_cache.coffee Outdated Show resolved Hide resolved
@sujeshthekkepatt
Copy link
Contributor Author

@erdii I have updated it. Now how are the tests need to be written? Need to have,

  1. mset functionality test
  2. mset maxkeys check
  3. ttl integer check test

Any other tests ?

@erdii erdii requested review from erdii and daluf and removed request for erdii September 5, 2019 12:01
daluf
daluf approved these changes Sep 5, 2019
View reviewed changes
_src/lib/node_cache.coffee Show resolved Hide resolved
@daluf daluf merged commit abe8a44 into node-cache:master Sep 5, 2019
@daluf daluf mentioned this pull request Sep 5, 2019
Closed
@sujeshthekkepatt sujeshthekkepatt deleted the mset-feature branch September 5, 2019 12:37
@Omrisnyk Omrisnyk mentioned this pull request Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erdii erdii erdii requested changes

@daluf daluf daluf approved these changes

Assignees

@daluf daluf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sujeshthekkepatt @erdii @daluf