fix(backport): memory leaks due to timer references outliving the timers (#2773) #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2773) * fix: remove unused setInterval spy * fix: delete timer references after callback This way we don't hold any strong reference to potentially large setTimeout/setImmediate contexts any more. Since we use neither `clearTimeout`, nor `clearImmediate`, we can just ignore those cases and don't need to install spies to handle deliberate clears.
mikicho
approved these changes
Aug 20, 2024
|
Thanks! 🎉 |
|
🎉 This PR is included in version 13.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 14.0.0-beta.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply backports the fix for #2771 to the main branch / v13. Should be worth it & low risk enough I think.