Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh/prezto: add package option #5938

Merged
merged 1 commit into from
Jan 9, 2025
Merged

zsh/prezto: add package option #5938

merged 1 commit into from
Jan 9, 2025

Conversation

ShayKStage
Copy link
Contributor

@ShayKStage ShayKStage commented Oct 7, 2024 •
edited
Loading

Description

Adds a package option to programs.zsh.prezto, allowing it to be overridden.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}

{long description}

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

The meta.maintainers list contains nickhu but they don't seem to be in the modules/lib/maintainers.nix file.
Edit: It's probably @NickHu

@github-actions github-actions bot added the shell label Oct 7, 2024
@stale Stale
Copy link

stale bot commented Jan 9, 2025

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Jan 9, 2025
@stale stale bot removed the status: stale label Jan 9, 2025
@teto
Copy link
Collaborator

teto commented Jan 9, 2025

could you rebase and push ?

@ShayKStage
zsh/prezto: add package option
aada6a7 
Allow setting a custom package for `programs.zsh.prezto`.
@ShayKStage ShayKStage force-pushed the zsh/add-prezto-package branch from 49d1113 to aada6a7 Compare January 9, 2025 09:42
@ShayKStage
Copy link
Contributor Author

I think (hope) this was the correct way to do it.

@teto teto merged commit 01f40d5 into nix-community:master Jan 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

Assignees
No one assigned
Labels
shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShayKStage @teto