-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taskwarrior: support taskwarrior3 migration #5782
taskwarrior: support taskwarrior3 migration #5782
Conversation
Support taskwarrior3 migration, following the approach in [1] to avoid breaking changes. [1]: NixOS/nixpkgs#303632 Closes: nix-community#5310 Link: nix-community#5782
dc63b75
to
b9c9bd0
Compare
Support taskwarrior3 migration, following the approach in [1] to avoid breaking changes. [1]: NixOS/nixpkgs#303632 Closes: nix-community#5310 Link: nix-community#5782
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff looks good to me 👍
(Note: I didn't test the changes as I don't use this program anymore.)
The default package should perhaps be set to taskwarrior3
for stateVersion
s more recent than the current stable?
This would be more consistent with what is being tested in the module test too.
Did you find a better alternative for your needs?
Users not already on taskwarrior3 receive the following warning:
Avoiding the breaking change of setting
Are you referring to the following: diff --git a/tests/modules/programs/taskwarrior/taskwarrior.nix b/tests/modules/programs/taskwarrior/taskwarrior.nix
index f21198f5732b..ea6cde3a1316 100644
--- a/tests/modules/programs/taskwarrior/taskwarrior.nix
+++ b/tests/modules/programs/taskwarrior/taskwarrior.nix
@@ -16,6 +16,7 @@ with lib;
include /my/stuff
urgency.user.tag.test.coefficient=-42.42
'';
+ package = pkgs.taskwarrior3;
};
test.stubs.taskwarrior = { }; I added this to verify that |
LGTM, I agree with following the nixpkgs approach. I am not sure if setting a taskwarrior3 in the test is a good idea. In my opinion, it's better to ensure that the default option is valid than checking that the example option is. |
This other PR has been merged and covers the taskwarrior-sync part: #5802 |
Support taskwarrior3 migration, following the approach in [1] to avoid breaking changes. [1]: NixOS/nixpkgs#303632 Closes: nix-community#5310 Link: nix-community#5782
b9c9bd0
to
aaebdea
Compare
Thanks! I've adjusted for the previously merged taskwarrior-sync PR and merged this PR to master now 🙂 |
Support taskwarrior3 migration, following the approach in [1] to avoid breaking changes. [1]: NixOS/nixpkgs#303632 Closes: nix-community#5310 Link: nix-community#5782
Support taskwarrior3 migration, following the approach in [1] to avoid breaking changes. [1]: NixOS/nixpkgs#303632 Closes: nix-community#5310 Link: nix-community#5782
Support taskwarrior3 migration, following the approach in [1] to avoid breaking changes. [1]: NixOS/nixpkgs#303632 Closes: nix-community#5310 Link: nix-community#5782
Support taskwarrior3 migration, following the approach in [1] to avoid breaking changes. [1]: NixOS/nixpkgs#303632 Closes: nix-community#5310 Link: nix-community#5782
Support taskwarrior3 migration, following the approach in [1] to avoid breaking changes. [1]: NixOS/nixpkgs#303632 Closes: nix-community#5310 Link: nix-community#5782
Description
Support taskwarrior3 migration, following the approach in NixOS/nixpkgs#303632 to avoid breaking changes.
Closes: #5310
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
taskwarrior-sync.nix
taskwarrior.nix