Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade programs.taskwarrior to use taskwarrior3 #5310

Closed
cloudlena opened this issue Apr 20, 2024 · 6 comments · Fixed by #5782
Closed

Upgrade programs.taskwarrior to use taskwarrior3 #5310

cloudlena opened this issue Apr 20, 2024 · 6 comments · Fixed by #5782
Assignees
@rycee @sumnerevans @berbiche
Labels
feature request status: stale

Comments

@cloudlena
Copy link
Contributor

cloudlena commented Apr 20, 2024 •
edited
Loading

Currently, programs.taskwarrior.package defaults to pkgs.taskwarrior. A new version of Taskwarrior was released, so we should update the default to pkgs.taskwarrior3.
@aktaboot
Copy link

since the taskwarrior package is still in nixpkgs and people might not have migrated yet, I think we should still keep it to pkgs.taskwarrior. It can easily be set manually to taskwarrior3.

I don't think a breaking change should be imposed on users without notice

@cloudlena
Copy link
Contributor Author

Thanks, @aktaboot. I see your point.

I'm not sure how this is handled usually. Would you just wait for some time and then change it later, or how would you proceed?

@aktaboot
Copy link

Yes, eventually it will roll out, but really unsure when.

@stale Stale
Copy link

stale bot commented Jul 26, 2024

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

  • If this is resolved, please consider closing it so that the maintainers know not to focus on this.
  • If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

  • If you are also experiencing this issue, please add details of your situation to help with the debugging process.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

@stale stale bot added the status: stale label Jul 26, 2024
@mdietrich16
Copy link

What about services.taskwarrior-sync? AFAIK (still a newbie to Nix) there is no option to explicitly set the used taskwarrior pkg to taskwarrior3 instead of taskwarrior.

@aktaboot
Copy link

@mdietrich16 for taskwarrior3, you can just set programs.taskwarrior.package = pkgs.taskwarrior3;
for the sync server module, I have a thing that I should upstream soon

trueNAHO added a commit to trueNAHO/home-manager that referenced this issue Aug 30, 2024
@trueNAHO
taskwarrior: support taskwarrior3
aaf3649 
Closes: nix-community#5310
Link: NixOS/nixpkgs#303632
Link: nix-community#5782
trueNAHO added a commit to trueNAHO/home-manager that referenced this issue Aug 30, 2024
@trueNAHO
taskwarrior: support taskwarrior3 migration
c3ade6b 
Support taskwarrior3 migration, following the approach in [1] to avoid
breaking changes.

[1]: NixOS/nixpkgs#303632

Closes: nix-community#5310
Link: nix-community#5782
@trueNAHO trueNAHO mentioned this issue Aug 30, 2024
Merged
6 tasks
trueNAHO added a commit to trueNAHO/home-manager that referenced this issue Aug 30, 2024
@trueNAHO
taskwarrior: support taskwarrior3 migration
dc63b75 
Support taskwarrior3 migration, following the approach in [1] to avoid
breaking changes.

[1]: NixOS/nixpkgs#303632

Closes: nix-community#5310
Link: nix-community#5782
trueNAHO added a commit to trueNAHO/home-manager that referenced this issue Aug 30, 2024
@trueNAHO
taskwarrior: support taskwarrior3 migration
b9c9bd0 
Support taskwarrior3 migration, following the approach in [1] to avoid
breaking changes.

[1]: NixOS/nixpkgs#303632

Closes: nix-community#5310
Link: nix-community#5782
@rycee rycee closed this as completed in aaebdea Sep 7, 2024
PerchunPak pushed a commit to PerchunPak/home-manager that referenced this issue Sep 17, 2024
@trueNAHO @PerchunPak
taskwarrior: support taskwarrior3 migration
7961fb2 
Support taskwarrior3 migration, following the approach in [1] to avoid
breaking changes.

[1]: NixOS/nixpkgs#303632

Closes: nix-community#5310
Link: nix-community#5782
brckd pushed a commit to brckd/home-manager that referenced this issue Sep 24, 2024
@trueNAHO @brckd
taskwarrior: support taskwarrior3 migration
75ee0b3 
Support taskwarrior3 migration, following the approach in [1] to avoid
breaking changes.

[1]: NixOS/nixpkgs#303632

Closes: nix-community#5310
Link: nix-community#5782
Mikilio pushed a commit to Mikilio/home-manager that referenced this issue Oct 11, 2024
@trueNAHO @Mikilio
taskwarrior: support taskwarrior3 migration
bedf207 
Support taskwarrior3 migration, following the approach in [1] to avoid
breaking changes.

[1]: NixOS/nixpkgs#303632

Closes: nix-community#5310
Link: nix-community#5782
Noodlez1232 pushed a commit to Noodlez1232/home-manager that referenced this issue Nov 21, 2024
@trueNAHO @Noodlez1232
taskwarrior: support taskwarrior3 migration
6b548f4 
Support taskwarrior3 migration, following the approach in [1] to avoid
breaking changes.

[1]: NixOS/nixpkgs#303632

Closes: nix-community#5310
Link: nix-community#5782
colonelpanic8 pushed a commit to colonelpanic8/home-manager that referenced this issue Dec 30, 2024
@trueNAHO @colonelpanic8
taskwarrior: support taskwarrior3 migration
7ec1088 
Support taskwarrior3 migration, following the approach in [1] to avoid
breaking changes.

[1]: NixOS/nixpkgs#303632

Closes: nix-community#5310
Link: nix-community#5782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rycee rycee

@sumnerevans sumnerevans

@berbiche berbiche

Labels
feature request status: stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

taskwarrior: support taskwarrior3 migration trueNAHO/home-manager
6 participants
@rycee @cloudlena @sumnerevans @berbiche @mdietrich16 @aktaboot