resolved issue Include OSM link somewhere #54 #150
Conversation
added button to link OSM to same map extent.
src/Map/Map.jsx
Outdated
| @@ -42,6 +42,24 @@ const style = { | |||
| height: '100vh', | |||
| } | |||
|
|
|||
| const button_style = { | |||
There was a problem hiding this comment.
it's ok for now to define in JS but eventually we should move all that stuff to css files
There was a problem hiding this comment.
I think it could be part of the project to determine how styles are managed! CSS files on a per-component basis are surely an option but there's plenty more. But yeah, consistency is key :-)
There was a problem hiding this comment.
Maybe I should just stay out of the review for web dev stuff😄
There was a problem hiding this comment.
yes, as more css could be the part I created new css file for Map component @chrstnbwnkl
|
sure I will make changes.. |
|
Thanks, works for me. WDYT @chrstnbwnkl? |
|
@nilsnolde I have made the necessary changes as you suggested And a question GSOC related for how much week should I keep deadline of project on my proposal right now I have kept it for 10 weeks and divided the work according to it. |
src/Map/Map.css
Outdated
| @@ -0,0 +1,23 @@ | |||
| .osm-button { | |||
There was a problem hiding this comment.
Adding that class here with all those custom styles is not necessary, please take a look at the UI component library we're using. Hint: take a look at the Directions/Isochrone button in the top right when the sidebar is collapsed.
|
|
| @@ -0,0 +1,12 @@ | |||
| #osm-button { | |||
🛠️ Fixes Issue
issue resolved #54
👨💻 Changes proposed
added button "open OSM" to valhalla web app to link OSM with same map extent and zoom level.
📷 Screenshots