Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: align built-in and plugin rule commit behavior #85

Merged
merged 1 commit into from
Jan 1, 2019
Merged

cli: align built-in and plugin rule commit behavior #85

merged 1 commit into from
Jan 1, 2019

Conversation

nilslice
Copy link
Owner

@nilslice nilslice commented Jan 1, 2019

From #83 by @aroch:

Aligning the behavior between built-in rules and rules run via plugins. Will run all plugins before committing and if warnings occur, commit will get blocked.

Thanks, Rafi! Great catch here.

@aroch @nilslice
Fixes: #76 (#83)
f2ca9ce 
Aligning the behavior between built-in rules and rules run via plugins.
Will run all plugins before committing and if warnings occur, commit will get blocked.
@nilslice nilslice merged commit 1fd7957 into master Jan 1, 2019
@nilslice nilslice deleted the pr-83 branch January 1, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilslice @aroch