quickfix: regression on commit command #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilslice
commented
Mar 27, 2019
| "id": 101, | ||
| "name": "newnew", | ||
| "type": "int32" | ||
| }, |
There was a problem hiding this comment.
this indicates a change recorded by a protolock commit invocation, after changing the testdata/test.proto as seen below
nilslice
commented
Mar 27, 2019
| os.Exit(code) | ||
| if code != 0 { | ||
| os.Exit(code) | ||
| } |
There was a problem hiding this comment.
the reason to even handle this, is because in the future we may want to use other exit codes (see #102) to indicate other failure modes which can be properly interpreted by users' automated integration systems
|
@nilslice changes look good to me! Thanks for the quick reaction time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@evanlknapp - would you mind taking a look at this before I merge & cut a new release?