Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix afterEach/tearDown sync calling #263

Merged
merged 1 commit into from
Sep 11, 2014
Merged

Fix afterEach/tearDown sync calling #263

merged 1 commit into from
Sep 11, 2014

Conversation

avaly
Copy link
Contributor

@avaly avaly commented Sep 11, 2014

Currently having a sync tearDown method defined on a test module, makes the tests hang.

This PR address this issue.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.28%) when pulling e15f109 on avaly:fix/after-each-no-arguments into f231048 on beatfactor:master.

@beatfactor
Copy link
Member

Cool. Could you post a short test demo which would reproduce the issue? Thanks.

@beatfactor
Copy link
Member

Never mind, I got it.

beatfactor added a commit that referenced this pull request Sep 11, 2014
@beatfactor
Merge pull request #263 from avaly/fix/after-each-no-arguments
5873b68 
Fix afterEach/tearDown sync calling
@beatfactor beatfactor merged commit 5873b68 into nightwatchjs:master Sep 11, 2014
@avaly avaly deleted the fix/after-each-no-arguments branch September 11, 2014 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avaly @coveralls @beatfactor