-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ES6 modules JavaScript with webpack #258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrimesdev
force-pushed
the
feature/es6-webpack
branch
from
November 27, 2018 21:08
ed2c1ba
to
604c2b4
Compare
Are you going to integrate the webpack setup into gulp? (https://pawelgrzybek.com/using-webpack-with-gulpjs/) |
chrimesdev
force-pushed
the
feature/es6-webpack
branch
13 times, most recently
from
November 28, 2018 15:44
15227a6
to
4b8da8d
Compare
Use modules to expose components individual logic and compile them into a single JavaScript file using webpack and ES6. Refactor emergency banner JavaScript as an example. Still a work in progress, need to refactor the configuration and further components.
Setup eslint to check for linting errors within our JavaScript using the shared NHS.UK configuration for eslint. https://github.com/nhsuk/eslint-config-nhsuk
Create a gulp task to compile our JavaScript using the webpack gulp plugin. Deleting the old build folder and using the main dist folder for our built JavaScript.
The word 'to' was missing from the sentence for the instructions to wait for the feedback banner to display.
chrimesdev
force-pushed
the
feature/es6-webpack
branch
from
November 29, 2018 09:04
4b8da8d
to
d69e13a
Compare
Refactor the feedback banner JavaScript so that it can be imported as a module, using ES6 syntax.
Refactor the skip link JavaScript so that it can be imported as a module, using ES6 syntax.
chrimesdev
force-pushed
the
feature/es6-webpack
branch
from
November 29, 2018 09:05
d69e13a
to
91992aa
Compare
Refactor the header JavaScript so that it can be imported as a module, using ES6 syntax.
chrimesdev
force-pushed
the
feature/es6-webpack
branch
from
November 29, 2018 10:30
91992aa
to
5781149
Compare
Following the webpack development, clean up the gulp tasks to be more efficent.
Move the eslint configuration file into the tests/linters folder to be with the sass-lint configuration. Also run both the linters on the npm test command.
Setup htmlhint to lint our HTML and fix any issues that were reported in various pages and templates.
chrimesdev
force-pushed
the
feature/es6-webpack
branch
2 times, most recently
from
December 17, 2018 11:17
1534e66
to
c25418c
Compare
chrimesdev
force-pushed
the
feature/es6-webpack
branch
14 times, most recently
from
December 17, 2018 12:25
5b092a1
to
01bcd71
Compare
…ples Add documentation for importing ES6 JavaScript modules and also delete documentation for specific tools or technologies such as gulp and expressjs.
chrimesdev
force-pushed
the
feature/es6-webpack
branch
2 times, most recently
from
December 17, 2018 12:38
8c3b3a5
to
fd2f71a
Compare
The versioned assets should not included within the npm installation directory.
chrimesdev
force-pushed
the
feature/es6-webpack
branch
from
December 17, 2018 12:39
fd2f71a
to
af95188
Compare
The skip link js wasn't creating the click and blur events properly. Also added DOMContentLoaded event to all the imported components so they don't fire before DOM has loaded.
chrimesdev
force-pushed
the
feature/es6-webpack
branch
from
December 17, 2018 15:11
a078e3f
to
e6b33ea
Compare
chrimesdev
force-pushed
the
feature/es6-webpack
branch
from
December 17, 2018 15:13
e6b33ea
to
3ecd825
Compare
Have added a |
mcheung-nhs
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use modules to expose components individual logic and compile them into a single JavaScript file using webpack and ES6. Refactor emergency banner JavaScript as an example. Still a work in progress, need to refactor the configuration and further components.