Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version lock for rack-protection #93

Closed
thenathanjones opened this issue Oct 6, 2022 · 3 comments · Fixed by #94
Closed

Remove version lock for rack-protection #93

thenathanjones opened this issue Oct 6, 2022 · 3 comments · Fixed by #94

Comments

@thenathanjones
Copy link

Hey folks,

omniauth-apple/omniauth-apple.gemspec

Line 41 in 04793ea

spec.add_dependency 'rack-protection', '~> 2.0'

According to the referenced issue this problem has now been resolved. Can this requirement please be removed now? We have already upgraded to the later version, but this lock is forcing a downgrade for us.

Thanks!
Nathan
nov added a commit to nov/omniauth-apple that referenced this issue Oct 9, 2022
@nov
rack-protection.rb is back in rack-protection v3.0.1
42ad156 
ref.) sinatra/sinatra#1814

close nhosoya#93
@nov nov mentioned this issue Oct 9, 2022
Merged
nov added a commit to nov/omniauth-apple that referenced this issue Oct 9, 2022
@nov
rack-protection.rb is back in rack-protection v3.0.1
8566f5b 
ref.) sinatra/sinatra#1814

close nhosoya#93
@nov nov closed this as completed in #94 Oct 9, 2022
@thenathanjones
Copy link
Author

Heya @nov! Any idea when you'll be publishing this change to Rubygems? 🙏

@nov
Copy link
Collaborator

nov commented Oct 25, 2022

sorry for the delay.
I've released v1.2.1 with your changes.
thanks!

@thenathanjones
Copy link
Author

No need to apologise @nov thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rack-protection.rb is back in rack-protection v3.0.1 nov/omniauth-apple
2 participants
@nov @thenathanjones