feat: allow multiple classes to be set from windowClass #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,7 +74,7 @@ export class DialogComponent implements OnInit, OnDestroy { | |||
| this.nodes.forEach(node => host.appendChild(node)); | |||
|
|
|||
| if (config.windowClass) { | |||
| host.classList.add(config.windowClass); | |||
| host.classList.add(...config.windowClass.split(/\s/).filter(x => x)); | |||
There was a problem hiding this comment.
Well, no and yes. It doesn't work natively. IE isn't supported by project's browserlist. If you like it work's with IE change the browserlist and required ployfills should be added automatically. Still works (and tested via Virtual Machines) with Edge 18 (supported by the browserlist)
There was a problem hiding this comment.
Let's change it to:
const classNames = config.windowClass.split(/\s/).filter(x => x);
classNames.forEach(name => host.classList.add(name))There was a problem hiding this comment.
Done, tested and pushed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When two classes added to
DialogConfig.windowClassaDOMException: Failed to execute 'add' on 'DOMTokenList': The token provided ('center dialog-lg') contains HTML space characters, which are not valid in tokens.is thrown.
Issue Number: N/A
What is the new behavior?
All classes added to
DialogConfig.windowClasswill be added to host element.Does this PR introduce a breaking change?
Other information