Skip to content

Nested dialog removes 'ngneat-dialog-hidden' too early from body #26

Closed
@fschick

Description

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

When nested dialog is closed, then class 'ngneat-dialog-hidden' is removed from body.

Expected behavior

Class 'ngneat-dialog-hidden' should removed from body after last dialog was closed.

Minimal reproduction of the problem with instructions

Open two (nested) dialogs, close the inner and review class list of 'body'.

What is the motivation / use case for changing the behavior?

Environment


Angular version: 9.1.11 - 11.2.0


Browser:
- [x] Chrome (desktop) version XX
- [x] Chrome (Android) version XX
- [x] Chrome (iOS) version XX
- [x] Firefox version XX
- [x] Safari (desktop) version XX
- [x] Safari (iOS) version XX
- [x] IE version XX
- [x] Edge version XX
 
For Tooling issues:
- Node version: v14.15.4  
- Platform:  Mac, Linux, Windows 

Others:

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions